Template talk:Review-Christgau

From Wikipedia, the free encyclopedia

[edit] Albums database table

So what is this '"albums" database table'? --PEJL 05:52, 12 June 2007 (UTC)

Never mind, just saw your post to WT:ALBUM. --PEJL 05:53, 12 June 2007 (UTC)

Is there a reason to provide two sets of inputs? That seems unnecessary to me, and just makes things more difficult for editors. As for which inputs to choose, I'm fine with the new honorable mention inputs (they might actually be better), but the other new inputs seem more cryptic to me. --PEJL 05:57, 12 June 2007 (UTC)

The new inputs are added to match the ratings codes used in the albums database table. I'm not confident these are a good idea either. / edgarde 16:42, 12 June 2007 (UTC)

I think it is a bad idea to support two sets of inputs. I see no reason to support these until the possible time in the future when the database table is posted, if it is posted with only these values (as opposed to in a more readable format). --PEJL 20:11, 12 June 2007 (UTC)

[edit] Subtle difference with both "id" and "name" attributes

I just noticed that get_artist.php URLs which include a "name" parameter in addition to an "id" parameter (example) generate a slightly different page from those with just the "id" parameter (example). Specifically, the title of the page is different. That might explain why many URLs contain both parameters. Nevertheless, I think it is fine for this template to include just the "id" attribute, but perhaps we could get the webmaster of the robertchristgau.com site to improve the title of the page instead. Edgarde, you were in contact with him, right? --PEJL 22:30, 26 June 2007 (UTC)

The name part (when using "id+name") seems to be supplying the page title (example), so asking for correct page titles from IDs might be making work for the webmaster (contact info here), tho Mr. Hull seems to be open to suggestions. Alternatives we could implement within Wikipedia:

• Modify the template to request the id+name URL when given name and artist parameters.
• Use whole URL with cgurl parameter.

/ edgarde 02:52, 27 June 2007 (UTC)

Fixing the get_artist.php file should be dead simple, it just needs to be changed to use the same logic for the page title as for the main header (which pulls the name from the database if the "name" attribute is not specified). Would you propose this to Mr. Hull? --PEJL 07:10, 27 June 2007 (UTC)